Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to solely using data.table internally #124

Open
martinju opened this issue Oct 30, 2019 · 1 comment
Open

Switch to solely using data.table internally #124

martinju opened this issue Oct 30, 2019 · 1 comment
Labels
postpone A task we have decided to postpone
Projects
Towards shapr 1.0.0

Comments

@martinju
Copy link
Member

After fixing #120, I suggest we change to the use of data.table throughout the package, only to convert to matrix when calling cpp-functions. The combination of data.frame, data.table and matrix of various dimensions complicates maintenance. See also #123
@martinju martinju added the postpone A task we have decided to postpone label Oct 31, 2019
@martinju
Copy link
Member Author

Almost all functions currently use matrix, so we will keep it like that for a while. Should convert everything to data.table (and convert to matrix only when required to call cpp-functions) sometime in the future.

@martinju martinju added this to To do in Towards shapr 1.0.0 Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
postpone A task we have decided to postpone
Projects
Towards shapr 1.0.0
  
To do
shapr 1.0.0
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@martinju