Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prefix Note/Warning to console print #259

Open
martinju opened this issue Mar 1, 2021 · 1 comment · Fixed by #267
Open

Add prefix Note/Warning to console print #259

martinju opened this issue Mar 1, 2021 · 1 comment · Fixed by #267

Comments

@martinju
Copy link
Member

martinju commented Mar 1, 2021

We print a series of "messages" to the console when e.g. a model does not store feature label classes. Either switch to using warning() or prefix the message with something like "Success with note: ..." to clarify to the reader that it completed fine, but that the content of the message should be noted".

@martinju
Copy link
Member Author

This is not fixed for all cases. Reopening. May also consider switching to using rlang::inform() instead of message() to give information in white text instead of red (as for warning/errors).

@martinju martinju reopened this Sep 20, 2021
@martinju martinju added this to To do in Towards shapr 1.0.0 Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

1 participant