Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallelization #38

Open
martinju opened this issue Apr 11, 2019 · 2 comments
Open

Parallelization #38

martinju opened this issue Apr 11, 2019 · 2 comments
Assignees
Labels
postpone A task we have decided to postpone

Comments

@martinju
Copy link
Member

martinju commented Apr 11, 2019

We should add 4 arguments for parallelization:

  1. One concerning parallelization of the predictions method (which is passed to prediction_vector)
  2. One for parallelization of the sampling method when either the Gaussian or copula method is used.
  3. One which concerns parallelization over test samples in compute_kshap
  4. One for parallelization of distance computation in prepare_kshap.

We should also add a test checking that either 3 or both of 1 and 2 are set to 1 core to avoid parallelization within parallelizations.

@martinju martinju added postpone A task we have decided to postpone and removed postpone A task we have decided to postpone labels Nov 26, 2019
@martinju
Copy link
Member Author

We have implemented parallellization within the prepare_data function of class ctree on the ctree branch, see f8734aa.

@martinju martinju added the postpone A task we have decided to postpone label Nov 26, 2019
@martinju martinju mentioned this issue Nov 12, 2020
@martinju
Copy link
Member Author

Currently, the approach in #244 seems to be the best way to handle this.

@martinju martinju added this to To do in Towards shapr 1.0.0 Oct 4, 2021
@martinju martinju added this to the Parallellization milestone Jan 4, 2022
@martinju martinju self-assigned this Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
postpone A task we have decided to postpone
Projects
Status: Done
Development

No branches or pull requests

1 participant