Only query Gyms that have been scanned recently (and are still active).

[tomballgithub]

Expected Behavior

In my area over the last month multiple gyms have been removed from the game. I am receiving reports from users that the maps have disappeared but are still on the map. The expected behavior would be gyms that have been removed from game are removed from the map. You can detect these gyms by looking for gyms with an old 'last scanned' date

Current Behavior

Gyms remain in the database and map unless database is cleared or gym manually removed

Possible Solution

Allow the option to automatically remove gyms with last_scanned > X days
Or better yet detect if a gym is no longer present and remove it

Steps to Reproduce (for bugs)

1. Explained above

Context

It causes a quality of life issue with map users. They go to a gym that is not present

Your Environment

• Version used:
• Environment name and version (e.g. Python 2.7):
• Operating System and version (desktop or mobile):
  Ubunto 16.04 VPS

[tomballgithub]

PR #2281 does fix the issue. We can close this issue when PR gets approved.

[tomballgithub]

PR 2281 no longer fixes the issue to my satisfaction. That PR changed into a database pruning PR and the gym now persists for 7 days before being removed and only if enabled via command line. We need something faster to avoid issues/complaints/alerts and user dissatisfaction. Original PR fix was to prune after 24 hours. Simply hiding the gyms after 24 hours if no scan would be sufficient.

[sebastienvercammen]

Reflagged from "has pr" to "help wanted".

@tomballgithub is correct that we need to query Gyms only if they've been scanned within the last x hours. This is unrelated to the database cleanup.

Just a friendly reminder that your RM team is currently enjoying their holidays 😊 So don't worry if things are taking a while, we'll be back after New Year's! ❤️

[sebastienvercammen]

To come back to this issue, I can think of at least two different setups:

• Map with active scanners that has live data. For these, querying only the recently updated gyms makes sense.
• Static map with just the locations and no more active scanning. Querying only the recently updated gyms doesn't make sense, and updating our code to filter them by default would break these maps.

As a middle ground, the DB cleaner rework #2383 has configurable settings to shorten/lengthen/disable data pruning (including for gyms), which solves all use cases.