Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate unused constant in PharInvocationResolver #35

Open
ohader opened this issue May 13, 2019 · 0 comments
Open

Deprecate unused constant in PharInvocationResolver #35

ohader opened this issue May 13, 2019 · 0 comments

Comments

@ohader
Copy link
Member

ohader commented May 13, 2019

Constant ASSERT_INTERNAL_INVOCATION is not used anymore since eb6607f#diff-0dd07cb25bec3476d9fc1d8a3db389b3L59

Asserting internal alias invocation just did not work out in a simple example like this

require('/path/bundle.phar');
// which internally does e.g. include('phar://bndl/vendor/autoload.php')
// given that Phar stub loads `autoload.php` using an internal alias
$object = new BundledClass();
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant