Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set-version no-docs option looks wrong #38

Open
gilbertsoft opened this issue Sep 27, 2021 · 1 comment
Open

set-version no-docs option looks wrong #38

gilbertsoft opened this issue Sep 27, 2021 · 1 comment
Labels
breaking This might be a breaking change bug Something isn't working major version Candidate for next major version

Comments

@gilbertsoft
Copy link
Contributor

The input type of the no-docs option should imho be NO_VALUE see

tailor/src/Command/Extension/SetExtensionVersionCommand.php

Line 42 in 2b4fa52

->addOption('no-docs', '', InputOption::VALUE_OPTIONAL, 'Disable version update in documentation settings', false);

@o-ba
Copy link
Member

o-ba commented Sep 27, 2021

Yes, that sounds reasonable. Do you want to create a PR?

gilbertsoft added a commit to gilbertsoft/tailor that referenced this issue Nov 17, 2021
@gilbertsoft
[BUGFIX] Fix no-docs input option
b419a07 
Fixes TYPO3#38
@gilbertsoft gilbertsoft mentioned this issue Nov 17, 2021
Closed
gilbertsoft added a commit to gilbertsoft/tailor that referenced this issue Nov 17, 2021
@gilbertsoft
[BUGFIX] Fix no-docs input option
227b112 
Fixes TYPO3#38
@o-ba o-ba added breaking This might be a breaking change bug Something isn't working major version Candidate for next major version labels Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking This might be a breaking change bug Something isn't working major version Candidate for next major version
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUGFIX] Fix no-docs input option gilbertsoft/tailor
2 participants
@o-ba @gilbertsoft