Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TJDB: Fix icon for '+ Add relation' button as per design #9699

Open
akshaysasidrn opened this issue May 14, 2024 · 4 comments · May be fixed by #9747 or #9780
Open

TJDB: Fix icon for '+ Add relation' button as per design #9699

akshaysasidrn opened this issue May 14, 2024 · 4 comments · May be fixed by #9747 or #9780
Assignees
@parthy007
Labels
bug Something isn't working database
Milestone
Database 1.1.1

Comments

@akshaysasidrn
Copy link
Collaborator

Version Information

v2.42.0

Environment

all

What is the expected behaviour?

Should conform as per design file

What is the current behaviour?

image
@akshaysasidrn akshaysasidrn added bug Something isn't working database labels May 14, 2024
@akshaysasidrn akshaysasidrn added this to the Database 1.1.1 milestone May 14, 2024
@parthy007 parthy007 self-assigned this May 16, 2024
@parthy007
Copy link
Collaborator

Is it already fixed?
Screenshot 2024-05-16 at 12 47 26 PM

@mansukh-tj
Copy link
Collaborator

No, See design
image

vs

current behavior

Screenshot 2024-05-16 at 2 28 53 PM

@parthy007
Copy link
Collaborator

No, See design image

vs

current behavior

Screenshot 2024-05-16 at 2 28 53 PM

I think all this is a part of this issue #9698

@akshaysasidrn akshaysasidrn linked a pull request May 16, 2024 that will close this issue
Fix: Standardise the drawer heading's styles in TJDB #9747
Open
@akshaysasidrn akshaysasidrn reopened this May 17, 2024
@mansukh-tj
Copy link
Collaborator

image

Current disabled state has to be changed to this

@parthy007 parthy007 linked a pull request May 20, 2024 that will close this issue
Open
@parthy007 parthy007 linked a pull request May 23, 2024 that will close this issue
Fix: TJDB icon for "Add relation" button when disabled #9780
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parthy007 parthy007

Labels
bug Something isn't working database
Projects
None yet
Milestone
Database 1.1.1
3 participants
@akshaysasidrn @parthy007 @mansukh-tj