Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unintended UI behavior in Horizontal divider component #9645

Closed
GrowwithNaveen opened this issue May 8, 2024 · 1 comment · May be fixed by #9942
Closed

Unintended UI behavior in Horizontal divider component #9645

GrowwithNaveen opened this issue May 8, 2024 · 1 comment · May be fixed by #9942

Comments

@GrowwithNaveen
Copy link
Collaborator

Issues:

  1. Unadjustable white space below the divider.
  2. Fixed height of the divider, preventing size customization.

Current behavior:

  • The Horizontal Divider component displays with an unchangeable amount of white space below it.
  • There is no option to modify the divider's height, resulting in a fixed size.

Expected behavior:

  • The white space below the divider should be adjustable or eliminated entirely.
  • Users should be able to customize the divider's height.

Steps to reproduce:

  1. Implement the Horizontal Divider component in your application.
  2. Observe the white space below the divider.
  3. Attempt to adjust the divider's height. You will find that the height remains fixed.

Attaching a video grab for reference,

Employee-directory-ToolJet.1.mp4
@overlyhonest
Copy link
Collaborator

Design review

  • Horizontal divider is fixed, but will need to look into vertical devider as well. The issues are
    • Vertical divider has uneven spacing on each side
    • Vertical divider can exist in zero columns

@GrowwithNaveen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment