Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noop if prebuild artifact's package doesn't match current variant #662

Open
Nimrodda opened this issue Aug 9, 2019 · 1 comment
Open
Labels
bug Indicates an unexpected problem or unintended behavior feature:apk Involves APKs feature:bundle Involves app bundles
Milestone

Comments

@Nimrodda
Copy link

Nimrodda commented Aug 9, 2019

My project has a few flavors. Each flavor has its own app ID.
I wanted to publish pre-built APKs per each flavor. After reading the documentation section about Uploading a pre-existing artifact I understood that I need to execute the following command per each flavor's apk:
./gradlew publishApk --artifact-dir path/to/flavor/apk

But executing the command above actually tried to publish that specific apk to all flavors!
I could see that the flavor specific publishing task, i.e. publishApkFlavorBuildType, was executed where the first one which matched the app ID of the provided apk was successful while the rest obviously failed.

I decided to try specifying the flavor specific publishApk task with --artifact-dir option, e.g.: ./gradlew publishApkFlavorBuildType --artifact-dir path/to/flavor/apk and 🎉 it worked!

I'm not sure if this is by design or a bug. If it's by design, please make the documentation clearer regarding flavor publishing.

Thank you for your awesome work! 😄

@Nimrodda Nimrodda added the docs Indicates issues where the documentation should be changed or enhanced label Aug 9, 2019
@SUPERCILEX
Copy link
Collaborator

Right, I would say that's expected since publishApk is a lifecycle task and doesn't actually do anything. However, I think it makes sense to try and parse a prebuild APK, check its package, and noop if the current build variant doesn't match.

@SUPERCILEX SUPERCILEX added bug Indicates an unexpected problem or unintended behavior feature:apk Involves APKs feature:bundle Involves app bundles and removed docs Indicates issues where the documentation should be changed or enhanced labels Aug 9, 2019
@SUPERCILEX SUPERCILEX changed the title Uploading pre-built apk documentation doesn't take flavors into account Noop if prebuild artifact's package doesn't match current variant Aug 9, 2019
@SUPERCILEX SUPERCILEX added this to the Backlog milestone Sep 21, 2019
@SUPERCILEX SUPERCILEX modified the milestones: Backlog, 2.7.0 Nov 16, 2019
@SUPERCILEX SUPERCILEX modified the milestones: 2.7.0, 2.8.0, Backlog Feb 16, 2020
@SUPERCILEX SUPERCILEX modified the milestones: 2.8.0, Backlog Jun 7, 2020
@SUPERCILEX SUPERCILEX modified the milestones: Backlog, 3.8.0 Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior feature:apk Involves APKs feature:bundle Involves app bundles
Projects
None yet
Development

No branches or pull requests

2 participants