Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VictoriaLogs UI sometimes loses log records in Firefox #6281

Open
eduardbareev opened this issue May 15, 2024 · 8 comments
Open

VictoriaLogs UI sometimes loses log records in Firefox #6281

eduardbareev opened this issue May 15, 2024 · 8 comments
Assignees
@Loori-R
Labels
bug Something isn't working victorialogs vmui

Comments

@eduardbareev
Copy link

eduardbareev commented May 15, 2024 •
edited

Describe the bug

The number of rows displayed doesn't match the number of rows returned by server.

The issue appears in following browsers:

  • Firefox 123.0 (mozilla tarball)
  • Firefox 124.0.1 (Fedora system package, clean VM install)

Chrome is not affected probably (never observed the issue)

Please see the video attached:
viclogslostrows.webm

To Reproduce

There is no sure way to reproduce this

Version

victoria-logs-20240514-010820-tags-v0.6.1-victorialogs-0-gc90e6de13b
@eduardbareev eduardbareev added the bug Something isn't working label May 15, 2024
@hagen1778
Copy link
Collaborator

@Loori-R could you please take a look?

@Loori-R Loori-R self-assigned this May 15, 2024
@Loori-R Loori-R added the vmui label May 16, 2024
@Loori-R
Copy link
Contributor

Loori-R commented May 17, 2024

@eduardbareev Hi, could you please send the server response when the logs is not displaying? This will help us identify the issue more easily.

@eduardbareev
Copy link
Author

@eduardbareev Hi, could you please send the server response when the logs is not displaying? This will help us identify the issue more easily.

While suffering from bugs VictoriaLogs cannot sensibly respond to queries, suddenly it started to return different records in different order in unpredictable manner, therefore I can't make it to return those three records.

However it turned out that I left one of browsers with developer tools open. Attached are screenshot and a HAR file whose last entry corresponds to what's on screenshot.

viclogsui.har.json

viclogsui

@eduardbareev
Copy link
Author

eduardbareev commented May 18, 2024 •
edited

@Loori-R My observation is that whether a record would be missing from rendering correlates to the length of its _msg. In Firefox on my machine, a record with _msg of 100k chars have 9/10 chances to not have a row in a resulting table. Small messages are always displayed. With this 3-records dataset viclogs_jsonlines.txt a second row is the one that gets absent almost always.

Loori-R added a commit that referenced this issue May 20, 2024
@Loori-R
vmui/logs: fix parsing issue with long _msg values #6281
028dbb8
@Loori-R Loori-R mentioned this issue May 20, 2024
Merged
@Loori-R
Copy link
Contributor

Loori-R commented May 20, 2024

@eduardbareev Thanks, your observations were very helpful! I have opened a pull request #6310 with the fix.

valyala added a commit that referenced this issue May 22, 2024
@Loori-R @valyala
vmui/logs: fix parsing long _msg values (#6310)
75bd183 
This PR fixes an issue where parsing long `_msg` values caused errors,
resulting in some log records not being displayed.

The error occurred due to partial processing of strings. In some cases,
a long record could be split into multiple chunks, causing only part of
the record to be processed instead of the entire entry.

#6281

Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>
valyala added a commit that referenced this issue May 22, 2024
@Loori-R @valyala
vmui/logs: fix parsing long _msg values (#6310)
252a196 
This PR fixes an issue where parsing long `_msg` values caused errors,
resulting in some log records not being displayed.

The error occurred due to partial processing of strings. In some cases,
a long record could be split into multiple chunks, causing only part of
the record to be processed instead of the entire entry.

#6281

Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>
@valyala
Copy link
Collaborator

valyala commented May 22, 2024

The fix has been included in VictoriaLogs v0.9.0. @eduardbareev , could you verify that the issue is fixed in this release?

@eduardbareev
Copy link
Author

The fix has been included in VictoriaLogs v0.9.0. @eduardbareev , could you verify that the issue is fixed in this release?

can't open /select/vmui/? in 0.9.0, says 404. /select/vmui/? is where "select/vmui - Web UI for VictoriaLogs" link on / (main page) points to

@eduardbareev
Copy link
Author

@valyala , checked 0.9.1, seems to me that the bug is gone.

By the way, I wanted to let you know about this feature request #6301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Loori-R Loori-R

Labels
bug Something isn't working victorialogs vmui
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@valyala @eduardbareev @hagen1778 @Loori-R