Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MetricsQL: Document stalness marker differences between default_rollup and last_over_time #6279

Closed
michalhosna opened this issue May 15, 2024 · 2 comments · Fixed by #6282
Closed

MetricsQL: Document stalness marker differences between default_rollup and last_over_time #6279

michalhosna opened this issue May 15, 2024 · 2 comments · Fixed by #6282

Comments

@michalhosna
Copy link

michalhosna commented May 15, 2024 •
edited

From the current(2024-05-15) MetricsQL documentation, it seems that the default_rollup and last_over_time functions are effectivly the same.

Even looking into the code, those functions seem the same

VictoriaMetrics/app/vmselect/promql/rollup.go

Line 2328 in 5e8c087

var rollupLast = rollupDefault

But there are somewhat hidden differences at minimum with staleness marker handling, which are non-obvious

VictoriaMetrics/app/vmselect/promql/eval.go

Line 1972 in 5e8c087

if *noStaleMarkers || funcName == "default_rollup" || funcName == "stale_samples_over_time" {

Those differences, as well as any other differences, should be documented in the MetricsQL documentation.
@AndrewChubatiuk AndrewChubatiuk mentioned this issue May 15, 2024
Merged
1 task
@AndrewChubatiuk
Copy link
Contributor

hey @michalhosna
thanks for a finding
added PR with a note about difference between these functions

hagen1778 pushed a commit that referenced this issue May 17, 2024
@AndrewChubatiuk
docs: added information about difference between default_rollup and l…
ce3cfd7 
…ast_over_time (#6282)

#6279
@hagen1778
Copy link
Collaborator

Thanks for reporting @michalhosna!
The issue should be addressed in this commit ce3cfd7

hagen1778 pushed a commit that referenced this issue May 17, 2024
@AndrewChubatiuk @hagen1778
docs: added information about difference between default_rollup and l…
23c7193 
…ast_over_time (#6282)

#6279
(cherry picked from commit ce3cfd7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@michalhosna @hagen1778 @AndrewChubatiuk