Is v27.0.0 specHelper.runAction<T>() generic type variable possible optional?

[WaBLin123]

Hi, new feature "specHelper support Action and Task generics" at v27.0.0 is awsome!
But is it possible for the user to decide the degree of protection? just a suggestion.
And what if generic type variable is not specific, will it return any?

By the way. specHelper.runAction response(specHelper.ts L34) type is always "UnwrapPromise<A["run"]>". because A(specHelper.ts L18) always extends Action, the conditional ternary operator is useless.
specHelper.runTask is the same.

actionhero/src/modules/specHelper.ts

Lines 18 to 45 in fb09661

	export async function runAction<A extends Action>(
	actionName: string,
	input: { [key: string]: any } = {}
	) {
	let connection;
	if (input.id && input.type === "testServer") {
	connection = input;
	} else {
	connection = await specHelper.buildConnection();
	connection.params = input;
	}
	connection.params.action = actionName;
	connection.messageId = connection.params.messageId || uuid.v4();
	const response: (A extends Action ? UnwrapPromise<A["run"]> : any) & {
	messageId?: string;
	error?: Error | string | any;
	requesterInformation?: ReturnType<WebServer["buildRequesterInformation"]>;
	serverInformation?: ReturnType<WebServer["buildServerInformation"]>;
	} = await new Promise((resolve) => {
	api.servers.servers.testServer.processAction(connection);
	connection.actionCallbacks[connection.messageId] = resolve;
	});
	return response;
	}

[evantahler]

I think you might be asking about overloading the type of the return type of specHelper.runAction<>(). In typescript, you can always re-assign a type.

Here's the response of a well-typed action, SessionCreate:

I can re-assign the response to, say a boolean if I wanted, but providing <any> to the runAction type:

[evantahler]

Perhaps we should allow folks to pass unknown to the runAction as well?

[WaBLin123]

Think for your answer, @evantahler . I may not express myself well.(I am not a native speaker of English) Please forgive me.

What I mean is that it is possible for specHelper.runAction to change the return type to be any if it does not provide type to the runAction type.

And, if I provide a ActionClass to the runAction type, the return type will be Action response & requestorInfomation.

like(I made some changes in local):

1. not provide generic

2. provide RecursiveAction

I think this is friendly to user who upgrade from the old version to v27, and allow user of the old version to have a buffer time to change.

Finally, if you offend, please forgive me.

[evantahler]

Don't worry about it! Your english is great!

I think that might be a really good change to assume a more generic type form specHelper.runAction<T>() if no action type T is provided. I wonder if we can do better than any though. Perhaps a default response of

any & {
      messageId?: string;
      error?: Error | string | any;
      requesterInformation?: ReturnType<WebServer["buildRequesterInformation"]>;
      serverInformation?: ReturnType<WebServer["buildServerInformation"]>;
    }

Might be more helpful.

Provide a PR and we can discuss the implementation there!

[WaBLin123]

I am happy to provide a PR! Thank you and have a good day!

[evantahler]

I think the & properties are required because the responses of Action.run probably won't include a error or the resqustorInformation - so we need to add it to the type