Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client_buggify can cause commit_unknown_result_fatal #10312

Open
atn34 opened this issue May 23, 2023 · 0 comments
Open

client_buggify can cause commit_unknown_result_fatal #10312

atn34 opened this issue May 23, 2023 · 0 comments

Comments

@atn34
Copy link
Collaborator

atn34 commented May 23, 2023

commit_unknown_result_fatal should not be thrown by client buggify since retry loops aren't expected to handle it.

This can happen under the following conditions:

  • The transaction has automatic idempotency enabled
  • The transaction does not perform any reads
  • commit_unknown_result is thrown from
    commit_unknown_result() });
  • No idempotency ids have ever been expired due to their age (not necessary)

Proposal:

  1. Move the client buggify error codes associated with the grv proxy into getReadVersion, where they probably belong anyway.
  2. Move the client buggify error codes associated with the commit proxy to directly before the commit rpc is made. Keep the potential buggify of commit_unknown_result for handling a successful commit.

This should make it safe to assume that the read version is set before determineCommitStatus (correcting the underlying problem)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant