Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ad devcontainer.json #11345

Merged
merged 2 commits into from Apr 29, 2024
Merged

Ad devcontainer.json #11345

merged 2 commits into from Apr 29, 2024

Conversation

PierreZ
Copy link
Contributor

@PierreZ PierreZ commented Apr 29, 2024 •
edited

This is a proposal to fix #11307. I managed to build FDB in the main branch, but I'm not using the docker daily to develop on FDB. There might be missing elements to actually use it to develop FDB, feel free to test it and contribute to the branch.

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

@PierreZ PierreZ changed the title Add add devcontainer.json Ad devcontainer.json Apr 29, 2024
@jzhou77 jzhou77 requested a review from ammolitor April 29, 2024 16:05
@jzhou77 jzhou77 closed this Apr 29, 2024
@jzhou77 jzhou77 reopened this Apr 29, 2024
@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr-clang-ide on Linux CentOS 7

  • Commit ID: 32f2f85
  • Duration 0:22:24
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: 32f2f85
  • Duration 0:58:17
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 32f2f85
  • Duration 0:59:57
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 32f2f85
  • Duration 1:07:23
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@ammolitor ammolitor merged commit d0eb68b into apple:main Apr 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ammolitor ammolitor Awaiting requested review from ammolitor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Open FoundationDB in a Dev Container
4 participants
@PierreZ @foundationdb-ci @ammolitor @jzhou77