Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If request is cancelled, stop waiting for a response from sourcekitd/clangd #883

Open
ahoppen opened this issue Oct 9, 2023 · 1 comment
Open

If request is cancelled, stop waiting for a response from sourcekitd/clangd #883

ahoppen opened this issue Oct 9, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@ahoppen
Copy link
Collaborator

ahoppen commented Oct 9, 2023

When a request is cancelled, we currently request cancellation in clangd/sourcekitd but still wait for the result. This means that we might still block the message handling queue for a request whose result we no longer care about.

What we should do instead is to immediately return a cancellation error for the cancelled request and no longer care about what sourcekitd/clangd returns to us.
@ahoppen ahoppen added the enhancement New feature or request label Oct 9, 2023
@ahoppen
Copy link
Collaborator Author

ahoppen commented Oct 9, 2023

Tracked in Apple’s issue tracker as rdar://116705684

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ahoppen