Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the SourceKitD/SourceKitDImpl layering #901

Open
ahoppen opened this issue Oct 13, 2023 · 1 comment
Open

Remove the SourceKitD/SourceKitDImpl layering #901

ahoppen opened this issue Oct 13, 2023 · 1 comment
Labels
refactoring An internal refactoring of the codebase

Comments

@ahoppen
Copy link
Collaborator

ahoppen commented Oct 13, 2023

From #899 (comment)

The SourceKitD protocol only has one real adopter SourceKitDImpl. It would probably make the code more readable if we remove the protocol and just use SourceKitDImpl.

When doing this, we might also consider want to consider adding a wrapper around SourceKitDImpl that keeps track of the currently active CodeCompletionSession, so that we can remove the CodeCompletionSession.completionSessions static variable.
@ahoppen ahoppen added the refactoring An internal refactoring of the codebase label Oct 13, 2023
@ahoppen ahoppen mentioned this issue Oct 13, 2023
Merged
@ahoppen
Copy link
Collaborator Author

ahoppen commented Oct 13, 2023

Tracked in Apple’s issue tracker as rdar://116921490

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring An internal refactoring of the codebase
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ahoppen