Remove CanImportExprSyntax and provide API to interpret an ExprSyntax as a VersionTupleSyntax
#1972
Comments
ahoppen
changed the title
CanImportExprSyntax and provide API to interpret an ExprSyntax as a VersionTupleSyntaxCanImportExprSyntax and provide API to interpret an ExprSyntax as a VersionTupleSyntax
|
Tracked in Apple’s issue tracker as rdar://113236781 |
ahoppen
added a commit
to StevenWong12/swift-syntax
that referenced
this issue
Mar 15, 2024
…ression node To make it easier to interpret the version passed to `canImport(MyModule, _version: <#version#>)`, add `ExprSyntax.interpretedAsVersionTuple` that takes eg. `1.2.3`, which got parsed as a member access `3` to the `1.2` float literal and re-parses it as a `VersionTupleSyntax`. This relaxation also allows string literals as version parameters to `#if canImport`. Fixes apple#1972 rdar://121070235 Co-Authored-By: Ziyang Huang <stevenhuang12@outlook.com>
ahoppen
added a commit
to ahoppen/swift-syntax
that referenced
this issue
Mar 19, 2024
…ression node To make it easier to interpret the version passed to `canImport(MyModule, _version: <#version#>)`, add `ExprSyntax.interpretedAsVersionTuple` that takes eg. `1.2.3`, which got parsed as a member access `3` to the `1.2` float literal and re-parses it as a `VersionTupleSyntax`. This relaxation also allows string literals as version parameters to `#if canImport`. Fixes apple#1972 rdar://121070235 Co-Authored-By: Ziyang Huang <stevenhuang12@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
canImportinside of#ifshould get parsed the same as in a normal expression position, eliminating the need forCanImportExprSyntax(sparked by link). This means that the parser won’t be able to generate diagnostics for invalid version numbers insidecanImportanymore.Instead, we should have a function on
ExprSyntaxthat interprets the expression (which would be aFloatingLiteralExprSyntaxfor eg.1.2) as aVersionTupleSyntax. If theExprSyntaxdoesn’t represent a version, that function should return a list of diagnostics.SwiftIfConfigwould then call that getter and would be responsible for reporting any errors that occur from interpreting theExprSyntaxof the_versionargument asVersionTupleSyntax.The text was updated successfully, but these errors were encountered: