Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SwiftCompilerSources: make fflush(stdout) in Test.swift work on Windows #73252

Open
eeckstein opened this issue Apr 25, 2024 · 0 comments
Open

SwiftCompilerSources: make fflush(stdout) in Test.swift work on Windows #73252

eeckstein opened this issue Apr 25, 2024 · 0 comments
Assignees
@atrick
Labels
compiler The Swift compiler in itself platform support task Windows Platform: Windows

Comments

@eeckstein
Copy link
Member

eeckstein commented Apr 25, 2024 •
edited

Description

It's currently disabled, because it does not compile on Windows
Therefore the swift-implemented unit tests don't work.

Also, enable public var standardError = CFileStream(fp: stderr) in Basic/Utils.swift

Reproduction

revert the "SwiftCompilerSources: exclude some low level file operations, which are not compilable on windows" commit from
#73247

Expected behavior

There should

Environment

Relevant once #73247 lands

Additional information

No response
@eeckstein eeckstein added bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. triage needed This issue needs more specific labels Windows Platform: Windows labels Apr 25, 2024
@AnthonyLatsis AnthonyLatsis added platform support task compiler The Swift compiler in itself and removed triage needed This issue needs more specific labels bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. labels Apr 25, 2024
@eeckstein eeckstein mentioned this issue May 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atrick atrick

Labels
compiler The Swift compiler in itself platform support task Windows Platform: Windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@atrick @eeckstein @AnthonyLatsis