Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The LoadableByAddress pass crashes when building SwiftCompilerSources on Windows with a 5.10 toolchain #73254

Open
eeckstein opened this issue Apr 25, 2024 · 5 comments
Open

The LoadableByAddress pass crashes when building SwiftCompilerSources on Windows with a 5.10 toolchain #73254

eeckstein opened this issue Apr 25, 2024 · 5 comments
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself crash Bug: A crash, i.e., an abnormal termination of software SILOptimizer Area → compiler: SIL optimization passes swift 5.10 Windows Platform: Windows

Comments

@eeckstein
Copy link
Member

Description

Crashes with a Unhandled use of FunctionRefInst

Reproduction

Once #73247 lands, revert the "SwiftCompilerSources: workaround a crash in the LoadableByAddress pass when building on Windows" commit of this PR

Expected behavior

no crash

Environment

reproducible with top-of main on Windows

Additional information

No response
@eeckstein eeckstein added bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. triage needed This issue needs more specific labels Windows Platform: Windows swift 5.10 labels Apr 25, 2024
@AnthonyLatsis AnthonyLatsis added compiler The Swift compiler in itself SILOptimizer Area → compiler: SIL optimization passes crash Bug: A crash, i.e., an abnormal termination of software and removed triage needed This issue needs more specific labels labels Apr 25, 2024
@hjyamauchi
Copy link
Collaborator

hjyamauchi commented Apr 25, 2024 •
edited

I wonder if this LoadableByAddress crash is the same as #72911 CC @compnerd

@compnerd
Copy link
Collaborator

compnerd commented Apr 25, 2024 •
edited

@eeckstein would you be able to test with @aschwaighofer's change? That might easily identify if the fix is already available or if this is another issue with LoadableByAddress.

Edit: aschwaighofer@1f2089a#diff-caf35bb7a5b0aa2a693bff10e95a6b5b903d77784166749ce226e94329a90f2cR3615

@aschwaighofer
Copy link
Member

This assert stems from an "older" part of the code the above fix will not fix it

@hjyamauchi
Copy link
Collaborator

@eeckstein https://github.com/apple/swift/pull/73270/files fixed #72911

@eeckstein
Copy link
Member Author

Seems to be fixed in Swift 6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself crash Bug: A crash, i.e., an abnormal termination of software SILOptimizer Area → compiler: SIL optimization passes swift 5.10 Windows Platform: Windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@compnerd @aschwaighofer @eeckstein @AnthonyLatsis @hjyamauchi