Empty FormattingOptions

[onelson]

Description:

I've been trying to build a plugin to talk to an LSP server written with lspower, and I'm finding it rejects request bodies that don't strictly conform to the LSP spec.

A concrete case (using 0.94.2) is a request for formatting looks like:

{
  "jsonrpc": "2.0",
  "id": "16",
  "method": "textDocument/formatting",
  "params": {
    "textDocument": {
      "uri": "file:///home/onelson/Projects/flux/check2.flux"
    },
    "options": {}
  }
}

to which the LSP server replies:

{
  "code": -32602,
  "message": "missing field `tabSize`"
}

Per the spec, both tabSize and insertSpaces are required fields for this payload, but both are missing for some reason.

Steps to reproduce:

Affected Versions:

0.94.2

Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

[onelson]

As an aside, I tried master-SNAPSHOT and wasn't able to test this specifically because of a similar problem much earlier during the capabilities checks in initialization. codeActionKind was missing from CodeActionClientCapabilities causing the initialization to fail.