Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: limiting python version to resolve compatibility issue #4743

Closed
wants to merge 1 commit into from

Conversation

sanspareilsmyn
Copy link
Contributor

What does this PR address?

Fixes #4742

Before submitting:

@sanspareilsmyn sanspareilsmyn requested a review from a team as a code owner May 17, 2024 13:37
@sanspareilsmyn sanspareilsmyn requested review from ssheng and removed request for a team May 17, 2024 13:37
@frostming
Copy link
Contributor

BentoML can actually be installed on 3.12 but not with PDM, since PDM requires a unified cross-python lock file.
As PDM install is only required in development, we should restrict the Python version to < 3.12 on dev only. But changing requires-python also affects those installed from PyPI and this is considered a breaking change.

So closing it now.

@frostming frostming closed this May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Cannot install Development environment using pdm
2 participants