Skip to content
This repository has been archived by the owner on Mar 2, 2022. It is now read-only.

search results - make better use of screen space #58

Open
yochannah opened this issue Nov 16, 2018 · 5 comments
Open

search results - make better use of screen space #58

yochannah opened this issue Nov 16, 2018 · 5 comments

Comments

@yochannah
Copy link

This is probably great for mobile, but looks a little odd on larger screens - can we use something like flexbox or css grid to take up a bit more of the horizontal space?

image

@Nikhil-Vats
Copy link
Member

I am working on this as well as many other styling issues I found. Screenshots are attached.
Screenshot 1
image
image
image

@Nikhil-Vats
Copy link
Member

Issues related to description -

  1. In Image 1, the component is not exactly in centre due to a right margin given to it.
  2. In Image 2, on certain screen sizes, visualisation is completely removed from the screen when we search for a component.
  3. In Image 3, even on normal laptop/desktop screen, when I search for certain components(I searched for components starting with 'j'), the visualisation disappeared while for some other searches(in Image 4, when I search for components starting with 'p' on same screen size as Image 3), the visualisation appears but is cropped and this looks bad.

Also we have search component at 3 places, here, in the components page and below popular components area on home page. So I think we should remove this particular search component as it is already available below on the Home page.

@yochannah
Copy link
Author

Rather than removing bio-pv, I think we'd like to make it work with the flow of the page. It's nice to have an attractive example early on.

If it's resizing we need to make sure the elements affecting its size don't make it jump about, I think. Does that sound reasonable?

@Nikhil-Vats
Copy link
Member

I am not suggesting to remove bio-pv, I am suggesting to remove just the search component below it. The visualisation and all will stay there. We can remove the search component because on the homepage itself there is one more search component just a little below this one(below the popular components area)? Did you get what I mean?

@Nikhil-Vats
Copy link
Member

I also noticed one more thing, on mobiles there is no option to go directly to the home page if we go to some other page. So, I think we should make the BioJS text on the top - a link to the homepage, what do you think?
image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants