Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

long strings not supported in records (cborgen limit) #308

Open
bnewbold opened this issue Sep 14, 2023 · 0 comments
Open

long strings not supported in records (cborgen limit) #308

bnewbold opened this issue Sep 14, 2023 · 0 comments
Labels
correctness Core protocol and data storage issues

Comments

@bnewbold
Copy link
Collaborator

cborgen, which indigo uses for dag-cbor serialization/deserialization, has a hard limit of 8 KByte on strings in CBOR objects. This breaks some valid records in the network today.

An example record, with a 19+ KByte embed description, is at://did:plc:yx2nfpytmmze4fau2qxw2c5a/app.bsky.feed.post/3k3lnbf3j262a
@bnewbold bnewbold added the correctness Core protocol and data storage issues label Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
correctness Core protocol and data storage issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bnewbold