Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

com.atproto.repo.describeRepo returns something unparseable by indigo #344

Open
karalabe opened this issue May 6, 2023 · 2 comments
Open

Comments

@karalabe
Copy link

karalabe commented May 6, 2023

I've got the following response on this endpoint:

{
  "handle": "go-bluesky-tester.bsky.social",
  "did": "did:plc:wflozfzpewefv46qof26vbzm",
  "didDoc": {
    "@context": [
      "https://www.w3.org/ns/did/v1",
      "https://w3id.org/security/suites/secp256k1-2019/v1"
    ],
    "id": "did:plc:wflozfzpewefv46qof26vbzm",
    "alsoKnownAs": [
      "at://go-bluesky-tester.bsky.social"
    ],
    "verificationMethod": [
      {
        "id": "#atproto",
        "type": "EcdsaSecp256k1VerificationKey2019",
        "controller": "did:plc:wflozfzpewefv46qof26vbzm",
        "publicKeyMultibase": "zQYEBzXeuTM9UR3rfvNag6L3RNAs5pQZyYPsomTsgQhsxLdEgCrPTLgFna8yqCnxPpNT7DBk6Ym3dgPKNu86vt9GR"
      }
    ],
    "service": [
      {
        "id": "#atproto_pds",
        "type": "AtprotoPersonalDataServer",
        "serviceEndpoint": "https://bsky.social"
      }
    ]
  },
  "collections": [
    "app.bsky.actor.profile",
    "app.bsky.feed.post",
    "app.bsky.graph.follow"
  ],
  "handleIsCorrect": true
}

The indigo parser chokes on it however because the diddoc does not have a type field and the parser wants one. Unsure who's at fault here, just that I don't know how to fix it.

@karalabe
Copy link
Author

karalabe commented May 6, 2023

The fault my originate from this repo not having a proper type spec for the didDoc, it just says "unknown", so generated app's can't really make heads or tails of it: https://atproto.com/lexicons/com-atproto-repo#comatprotorepodescriberepo

            "didDoc": {
              "type": "unknown"
            },

@devinivy
Copy link
Contributor

The response there appears valid to me per the lexicon, so moving this over to indigo.

@devinivy devinivy transferred this issue from bluesky-social/atproto Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants