Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getLatestCommit on Relay returns 500 for (some?) deleted accounts #621

Open
mackuba opened this issue Mar 15, 2024 · 2 comments
Open

getLatestCommit on Relay returns 500 for (some?) deleted accounts #621

mackuba opened this issue Mar 15, 2024 · 2 comments

Comments

@mackuba
Copy link

mackuba commented Mar 15, 2024

https://bsky.network/xrpc/com.atproto.sync.getLatestCommit?did=did:plc:pkmfz5soq2swsvbhvjekb36g
https://bsky.network/xrpc/com.atproto.sync.getLatestCommit?did=did:plc:ravrgr24ltd5oxft2mha6chc
https://bsky.network/xrpc/com.atproto.sync.getLatestCommit?did=did:plc:cw2oqmrjzpfaezhs6pp3bksy

HTTP/2 500 
vary: Origin
date: Fri, 15 Mar 2024 22:17:37 GMT
content-length: 0
strict-transport-security: max-age=63072000

The first one is a DID from an independent PDS where the owner (IIRC) has manually added a plc_tombstone operation to PLC because they thought it was needed. The second one is also a repo on another independent PDS, the repo doesn't seem to exist on the PDS anymore.

The third was a DID on a Bluesky PDS, so I'm assuming this might actually be happening for all deleted repos?

@mackuba
Copy link
Author

mackuba commented Mar 25, 2024

More examples:

did:plc:icjkfdhae2trwtx3ikmv62ii (maitake.us-west.host.bsky.network)
did:plc:5voyzxlltvyvfzw5umluvfu5 (bsky.gdgd.tokyo)
did:plc:g6klig5oawtvtqb7qnuyhhwb (bsky.gdgd.tokyo)

@bnewbold
Copy link
Collaborator

Thanks for reporting these! Sorry to leave these lingering.

We are planning to iterate on how identity and account lifecycle events are transmitted over the repo event stream ("firehose"), most likely deprecating the #handle and #tombstone events to use just #identity and #account. When we do that, the relay will be updated to have slightly different internal account state tracking. I think that we'll probably wait to debug these accounts until we do that update, and then ensure/test that tombstoned accounts are handled consistently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants