Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dynamic models crate workaround #3877

Open
webern opened this issue Apr 8, 2024 · 1 comment
Open

dynamic models crate workaround #3877

webern opened this issue Apr 8, 2024 · 1 comment
Assignees
@sam-berning
Labels
area/out-of-tree-builds Related to the efforts of making it easy to create builds outside of the main Bottlerocket repo

Comments

@webern
Copy link
Member

webern commented Apr 8, 2024

What I'd like:

While we are still working on settings extensions, we need a way to remove conditional compilation from all packages including apiserver and apiclient. To do this we should consider compiling all of the settings structs and choosing the right one for the variant at runtime.
@webern webern added type/enhancement New feature or request status/needs-triage Pending triage or re-evaluation labels Apr 8, 2024
@webern webern added area/out-of-tree-builds Related to the efforts of making it easy to create builds outside of the main Bottlerocket repo and removed type/enhancement New feature or request status/needs-triage Pending triage or re-evaluation labels Apr 8, 2024
@webern
Copy link
Member Author

webern commented May 7, 2024

The first idea was to build all the models into in an "uber model". The new approach is to dynamically load model "plugin" dylibs.

@webern webern mentioned this issue May 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sam-berning sam-berning

Labels
area/out-of-tree-builds Related to the efforts of making it easy to create builds outside of the main Bottlerocket repo
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@webern @sam-berning