Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OOTB: package builds should not be aware of image features #3883

Open
Tracked by #3615
webern opened this issue Apr 9, 2024 · 1 comment · May be fixed by #3962
Open
Tracked by #3615

OOTB: package builds should not be aware of image features #3883

webern opened this issue Apr 9, 2024 · 1 comment · May be fixed by #3962
Assignees
@jmt-lab
Labels
area/out-of-tree-builds Related to the efforts of making it easy to create builds outside of the main Bottlerocket repo type/enhancement New feature or request

Comments

@webern
Copy link
Member

webern commented Apr 9, 2024 •
edited

Some packages in Bottlerocket are built differently based on what image features are found in the variant Cargo.toml. We need packages to be unaware of variant and built the same for all variants.

In concert with bottlerocket-os/twoliter#193

These are the Bottlerocket packages affected:

packages/kernel-5.10/Cargo.toml
9:variant-sensitive = "platform"

packages/systemd/Cargo.toml
13:package-features = ["unified-cgroup-hierarchy"]

packages/kernel-5.15/Cargo.toml
9:variant-sensitive = "platform"

packages/os/Cargo.toml
9:variant-sensitive = true
27:package-features = [ "systemd-networkd" ]

packages/kernel-6.1/Cargo.toml
9:variant-sensitive = "platform"
@webern webern added type/enhancement New feature or request status/needs-triage Pending triage or re-evaluation area/out-of-tree-builds Related to the efforts of making it easy to create builds outside of the main Bottlerocket repo labels Apr 9, 2024
This was referenced Apr 9, 2024
Open
Open
@webern webern changed the title package builds should not be aware of image features OOTB: package builds should not be aware of image features Apr 9, 2024
This was referenced Apr 10, 2024
Merged
Merged
@bcressey bcressey mentioned this issue Apr 22, 2024
Merged
@yeazelm yeazelm removed the status/needs-triage Pending triage or re-evaluation label Apr 23, 2024
This was referenced Apr 24, 2024
Closed
Merged
@webern
Copy link
Member Author

webern commented May 7, 2024

We might have this done.

grep spec files for image-features in packages. If we don't find any we should try building without passing image features to the package builds.

@webern webern assigned webern and jmt-lab and unassigned bcressey and webern May 7, 2024
@webern webern linked a pull request May 15, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmt-lab jmt-lab

Labels
area/out-of-tree-builds Related to the efforts of making it easy to create builds outside of the main Bottlerocket repo type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DRAFT: update twoliter webern/bottlerocket
4 participants
@bcressey @webern @yeazelm @jmt-lab