Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading more marks does not work properly #278

Open
yasuokav opened this issue Nov 23, 2020 · 2 comments
Open

Loading more marks does not work properly #278

yasuokav opened this issue Nov 23, 2020 · 2 comments
Assignees
Labels

Comments

@yasuokav
Copy link

yasuokav commented Nov 23, 2020

Version: 2020.3

Step to reproduce:

  1. Add 31 marks
    1

  2. Go back to the top and refresh the page

  3. Back to the bottom, the last mark disappeared
    2

  4. Add another mark (Total: 32)

  5. The previous mark is disappeared
    3

In addition, the last loaded mark cannot be edited.

Uncaught TypeError: Cannot convert undefined or null to object
    at Function.keys (<anonymous>)
    at unmark.show_mark_info (unmark.loggedin.js?v=2020.3:163)
    at HTMLAnchorElement.<anonymous> (unmark.loggedin.js?v=2020.3:364)
    at HTMLDocument.dispatch (jquery-2.1.0.min.js:3)
    at HTMLDocument.y.handle (jquery-2.1.0.min.js:3)
function(k) {
    var p = 0;
    unmark.show_mark_info = function(a) {
        var e, n = a.data("mark"), t = k("#" + n).html(), r = jQuery.parseJSON(t), s = n.replace("mark-data-", ""), o = k("#mark-" + s).find(".note-placeholder").text(), l = (a.data("nofade"),
        null != r.mark_title ? r.mark_title : r.title);
        r.mark_title = l;
        var u = ""
          , d = Object.keys(r.tags).length <---------

Loaded marks:

{
"lookup_type":"all",
"marks":{
"0":{
"mark_id":"2",
"mark_title":null,
"notes":null,
"active":"1",
"created_on":"2020-11-23 18:15:12",
"archived_on":null,
"title":"Step 2: Watch a video walkthrough of Unmark",
"url":"https:\/\/www.notion.so\/cdevroe\/Unmark-Help-Video-walkthrough-of-Unmark-UI-e5efd1ed5eaf42298e67fb087e476f33",
"embed":null,
"label_id":"3",
"label_name":"Watch",
"tags":{
},
"nice_time":"23 minutes ago"
},
"1":{
"mark_id":"3",
"mark_title":null,
"notes":null,
"active":"1",
"created_on":"2020-11-23 18:15:12",
"archived_on":null,
"title":"Step 3: Discover new bookmarks",
"url":"https:\/\/www.notion.so\/cdevroe\/Unmark-Help-Discover-featured-bookmarks-2091a6b3871c4b29a209b72d5c3e9bca",
"embed":null,
"label_id":"7",
"label_name":"Do",
"tags":{
},
"nice_time":"23 minutes ago"
}
},
"page":"2",
"pages":2,
"per_page":30,
"total":32
@cdevroe
Copy link
Owner

cdevroe commented Dec 27, 2021

It looks like you might have found a bug with the infinite scroll page loading. It appears to be working on mobile, but not on Desktop. I'm going to see if I can verify this.

@cdevroe cdevroe self-assigned this Dec 27, 2021
@cdevroe cdevroe added the bug label Dec 27, 2021
@cdevroe
Copy link
Owner

cdevroe commented Dec 31, 2021

I dug into this a little, I am wondering if this only happens at certain viewport sizes. Unmark does some antiquated things with how it loads more marks... I think it'd be good to perhaps have this completely redone in the future. But for now, if someone has exactly 32 marks and a certain viewport size, it may just have to continue to have this bug. Unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants