Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Specify plugin platform #561

Open
dubisdev opened this issue Jul 16, 2022 · 2 comments
Open

feat: Specify plugin platform #561

dubisdev opened this issue Jul 16, 2022 · 2 comments

Comments

@dubisdev
Copy link
Contributor

Some plugins are oriented to a specific platform
image

We can use the os field in package.json to filter which plugins are shown to the user.

I think the best way would be to treat this field as npm or yarn treat it:

  • If os is not specified: we assume the plugin works in all platforms
  • If specified: we compare with process.platform and we filter the results
@glmagicworks
Copy link

There is so many plugin developers to get in touch, is not better to build an indice based on hotwords, like elasticsearch do, for example: "if this plugin has only 'macos' on the title or in it's description it's for mac, if this plugin has 'macos and windows' it's for both platforms" this would be great to solve the problem fast, before the developers can migrate to the new standard, a little thug but it works... 😅

@dubisdev
Copy link
Contributor Author

dubisdev commented Aug 17, 2022

Hi @gabriellacerda

I think this implementation is backwards compatible:
If there is no os specified the plugin would be shown to all users (just as now)

And if there is, we would just respect the developer decision

Is just a new API utility the developers could have to build their plugins. But nothing breaks if they don't want to use it.

@dubisdev dubisdev changed the title [Feature Request]: Specify plugin platform feat: Specify plugin platform Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants