Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link results should be clickable #20

Open
saxobroko opened this issue Oct 21, 2019 · 8 comments
Open

Link results should be clickable #20

saxobroko opened this issue Oct 21, 2019 · 8 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@saxobroko
Copy link
Contributor

On https://saxob.ga/ when you click you result I have made it go to the link in a new tab.

There are other ways to do it instead of opening the link, for exmaple you could make it click to copy.

@choraria choraria self-assigned this Oct 21, 2019
@choraria choraria added the enhancement New feature or request label Oct 21, 2019
@choraria
Copy link
Owner

@saxobroko - I intentionally did not want to hyperlink the result as that may not be what others may've wanted (well, quite honestly I had no way to know 😊).

I did try to have a click-to-copy icon made available next to it but just couldn't code it right :( I suppose that's something which we see in many of such services - a way to directly copy the short URL, without having to select it and then copy 'em manually.

Will see how soon I could make a click-to-copy option made available. Thanks for implementing the solution and sharing your feedback.

@saxobroko
Copy link
Contributor Author

Maybe adding a button next to the result that says "Copy" would make it better w3schools has a good page on this https://www.w3schools.com/howto/howto_js_copy_clipboard.asp

@choraria choraria added the good first issue Good for newcomers label Oct 21, 2019
@SIGSTACKFAULT
Copy link

Hacktoberfest Dibs!

@tulXoro
Copy link

tulXoro commented Jul 26, 2020

Is this still an issue? I'd like to try working on this if possible.

@saxobroko
Copy link
Contributor Author

Is this still an issue? I'd like to try working on this if possible.

yeah that would be great

@tulXoro
Copy link

tulXoro commented Jul 26, 2020

#44

I'm a little new to HTML and JavaScript so I don't know if it'll work the way intended.

@0xClint
Copy link

0xClint commented Oct 8, 2022

Is this issue solved? will this be tagged as hacktoberfest

@tulXoro
Copy link

tulXoro commented Oct 8, 2022

I opened a PR that implements this feature. I don't believe this will be tagged for hacktober fest though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants