Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable no-overlap checking #6893

Open
raynay-r opened this issue Apr 2, 2021 · 1 comment
Open

Configurable no-overlap checking #6893

raynay-r opened this issue Apr 2, 2021 · 1 comment
Labels

Comments

@raynay-r
Copy link

raynay-r commented Apr 2, 2021

For my use-case I need to load services dynamically from different JARs. I do this similar to the SerializationWhitelist, where I put a File into META-INF/services. Since the services i want to load come from different package I have multiple of these files with the same name, which is prevent by the no-overlap rule/check.

Here you make an exception for SerializationWhitelist, but prevent any other services from being loaded:
https://github.com/corda/corda/blob/ec92801904183ac92a75d62288c20b86dc879509/core/src/main/kotlin/net/corda/core/serialization/internal/AttachmentsClassLoader.kt#L147-#L161

Would it be possible to make a new configuration parameter which allows the user to supply a list of interface names which should be allowed to overlap? I really need this in my project and if you are willing to make the change I could try and provide a pull request.

@nargas-ritu
Copy link
Contributor

Created CORDA-4188 for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants