Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTelemetry spec v1.10 that Dapr uses needs to be updated to v1.25 #7703

Open
theperm opened this issue Apr 18, 2024 · 1 comment · May be fixed by #7735
Open

OpenTelemetry spec v1.10 that Dapr uses needs to be updated to v1.25 #7703

theperm opened this issue Apr 18, 2024 · 1 comment · May be fixed by #7735
Labels
good first issue Good for newcomers kind/bug Something isn't working P0
Milestone

Comments

@theperm
Copy link

theperm commented Apr 18, 2024

In what area(s)?

/area runtime

What version of Dapr?

1.13.2

Expected Behavior

The current OpenTelemetry specification is v1.25 and compliance with this version is required with some Observability platforms like Cisco Cloud Observability or else they do not understand how to visualise endpoint flow maps.

Changes to the v1.25 specification of trace spans for http server and client contexts state that the spans SHOULD contain the attributes :

http.request.method
server.address
server.port
url.full

There are additional attributes recommended and advisories for handling previous specifications so it would be worthwhile reviewing the implementation and the new specification and supporting some of the recommended attributes as well.

HTTP Sever: The following attributes can be important for making sampling decisions and SHOULD be provided at span creation time (if provided at all):

url.path
url.scheme
server.port
url.query
client.address
server.address
user_agent.original
http.request.header.

http.route MUST be provided at span creation time if and only if it's already available. If it becomes available after span starts, instrumentation MUST populate it anytime before span ends.

See v1.25.0/docs/http/http-spans.md

Additionally these attributes are required on all OpenTelemetry data:

telemetry.sdk.language string The language of the telemetry SDK. cpp Required  
telemetry.sdk.name string The name of the telemetry SDK as defined above. [1] opentelemetry Required  
telemetry.sdk.version string The version string of the telemetry SDK. 1.2.3 Required  

Actual Behavior

http.request.method is missing from http client span attributes
server.address is missing from http client span attributes
server.port is missing from http client span attributes
url.full is missing from http client span attributes
http.request.method is missing from http client span attributes

http.request.method is missing from http server t span attributes
server.address is missing from http server span attributes
server.port is missing from http server span attributes
url.path is missing from http server span attributes
url.scheme is missing from http server span attributes

Steps to Reproduce the Problem

Collect and trace info from Dapr and inspect the span attributes

Release Note

RELEASE NOTE: UPDATE OpenTelemetry specification to v1.25

@theperm theperm added the kind/bug Something isn't working label Apr 18, 2024
@theperm theperm changed the title OpenTelemetry spec OpenTelemetry spec Dapr uses is outdated v1.10 Apr 18, 2024
@theperm theperm changed the title OpenTelemetry spec Dapr uses is outdated v1.10 OpenTelemetry spec v1.10 that Dapr uses needs to be updated to v1.25 Apr 18, 2024
@JoshVanL JoshVanL added this to the v1.14 milestone Apr 18, 2024
@JoshVanL JoshVanL added good first issue Good for newcomers P0 labels Apr 18, 2024
@mikeee mikeee mentioned this issue May 7, 2024
38 tasks
@yaron2 yaron2 linked a pull request May 16, 2024 that will close this issue
@msfussell
Copy link
Member

msfussell commented May 28, 2024

As part of this update suggest that we also update to the latest OTEL v0.101.0.

Also see issue Replace sunsetted opencensus for metric/traces with Otel equivalent #7764

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers kind/bug Something isn't working P0
Projects
Status: Needs Owner
Development

Successfully merging a pull request may close this issue.

3 participants