dcr: Allow ticket purchasing for rpc spv wallets #2756

JoeGruffins · 2024-05-02T09:26:23Z

JoeGruffins · 2024-05-02T11:23:22Z

I guess the rpcwallet also needs to be a ticketPager

JoeGruffins · 2024-05-07T08:55:40Z

client/asset/dcr/rpcwallet.go

+var _ ticketPager = (*rpcWallet)(nil)
+
+func (w *rpcWallet) TicketPage(ctx context.Context, scanStart int32, n, skipN int) ([]*asset.Ticket, error) {
+	return make([]*asset.Ticket, 0), nil
+}


Without this there will be an error:

2024-05-07 08:50:36.970 [ERR] WEB: error retrieving ticket page for 42: ticket pagination not supported for this wallet

But it doesn't look like the pager is needed. Should this error be silence somewhere else?

Also the statuses are all unknown, which I think is a separate issue.

Without TicketPage will it show the tickets that have already voted?

Also the statuses are all unknown, which I think is a separate issue.

The native wallet doesn't show undefined.

I guess we should consider using the tx history db for paginating ticket history. At least for spv wallet but maybe for all. No need to do it in this PR though. Sounds like a bit of work.

Without TicketPage will it show the tickets that have already voted?

The already voted tickets always seem to go away. Without being a TicketPage you can't view any pages with under 10 tickets.

JoeGruffins · 2024-05-07T08:56:32Z

client/asset/dcr/rpcwallet.go

+	w.ticketCache.Lock()
+	defer w.ticketCache.Unlock()
+	if w.ticketCache.stamp.Add(ticketCacheExpiry).After(time.Now()) {
+		return w.ticketCache.tickets, nil
+	}


Sometimes this was returning tickets then none if called close together. I guess a cache is alright to have?

Maybe the cache can be made more intelligent to get statuses more correct.

JoeGruffins · 2024-05-07T08:58:22Z

This looks ok for purchasing tickets but viewing them afterwards seems to have a lot of problems still.

JoeGruffins · 2024-05-07T11:28:20Z

client/asset/dcr/rpcwallet.go

+func (w *rpcWallet) tickets(ctx context.Context, includeImmature bool) ([]*asset.Ticket, error) {
+	w.ticketCache.Lock()
+	defer w.ticketCache.Unlock()
+	if w.ticketCache.stamp.Add(ticketCacheExpiry).After(time.Now()) {


Can use time.Since

martonp · 2024-05-12T07:34:55Z

client/asset/dcr/dcr.go

+		if errors.Is(err, oldSPVWalletErr) {
+			return nil, nil
+		}


In this case the UI doesn't show any information that the current version of dcrwallet is too low. Might be helpful to show that.

Is there a reasonably easy way to do that? I don't expect the number of rpc+spv users will be high. If it's more that a few lines of work to properly communicate this message to the front end, I'm okay with how you have it, @JoeGruffins.

martonp · 2024-05-12T07:43:05Z

client/asset/dcr/rpcwallet.go

+var _ ticketPager = (*rpcWallet)(nil)
+
+func (w *rpcWallet) TicketPage(ctx context.Context, scanStart int32, n, skipN int) ([]*asset.Ticket, error) {
+	return make([]*asset.Ticket, 0), nil
+}


Without TicketPage will it show the tickets that have already voted?

Also the statuses are all unknown, which I think is a separate issue.

The native wallet doesn't show undefined.

buck54321

Can you configure the vsp for our harness beta wallet?

buck54321 · 2024-05-18T13:19:29Z

client/asset/dcr/dcr.go

+		if errors.Is(err, oldSPVWalletErr) {
+			return nil, nil
+		}


Is there a reasonably easy way to do that? I don't expect the number of rpc+spv users will be high. If it's more that a few lines of work to properly communicate this message to the front end, I'm okay with how you have it, @JoeGruffins.

buck54321 · 2024-05-18T13:25:43Z

client/asset/dcr/rpcwallet.go

+	// Calling w.rpcClient.GetTickets too close together will return no
+	// tickets for the second call. A ticket cache alleviates this.


It's a dcrwallet bug?

I think I was wrong about this. Removing for now.

buck54321 · 2024-05-18T13:38:22Z

client/asset/dcr/rpcwallet.go

+var _ ticketPager = (*rpcWallet)(nil)
+
+func (w *rpcWallet) TicketPage(ctx context.Context, scanStart int32, n, skipN int) ([]*asset.Ticket, error) {
+	return make([]*asset.Ticket, 0), nil
+}


I guess we should consider using the tx history db for paginating ticket history. At least for spv wallet but maybe for all. No need to do it in this PR though. Sounds like a bit of work.

JoeGruffins · 2024-05-20T05:26:48Z

Configuring beta wallet with the vsp https://github.com/decred/dcrdex/compare/b7484aa8719d11b1c97285d7410a58c035b7971a..ed4c676d50d7467941a233d26a7ba9664d3700f4

JoeGruffins · 2024-05-20T06:34:24Z

Looking again today I'm not seeing blank results. Removing the cache for now...

https://github.com/decred/dcrdex/compare/ed4c676d50d7467941a233d26a7ba9664d3700f4..916f2490e56b83ac40244c18957bf776fd88cf30

JoeGruffins · 2024-05-27T03:57:54Z

@buck54321 updated the dcrwallet version to latest

JoeGruffins force-pushed the suppressstakestatus branch from cdfa4ea to ea5b703 Compare May 2, 2024 11:22

JoeGruffins force-pushed the suppressstakestatus branch 5 times, most recently from a6713e3 to b7484aa Compare May 7, 2024 08:51

JoeGruffins commented May 7, 2024

View reviewed changes

JoeGruffins marked this pull request as ready for review May 7, 2024 08:57

JoeGruffins commented May 7, 2024

View reviewed changes

martonp reviewed May 12, 2024

View reviewed changes

buck54321 requested changes May 18, 2024

View reviewed changes

JoeGruffins force-pushed the suppressstakestatus branch from b7484aa to ed4c676 Compare May 20, 2024 05:26

JoeGruffins force-pushed the suppressstakestatus branch from ed4c676 to 916f249 Compare May 20, 2024 06:32

JoeGruffins force-pushed the suppressstakestatus branch from 916f249 to 51f55f5 Compare May 21, 2024 02:20

dcr: Allow ticket purchasing for rpc spv wallets

7c7bfc6

JoeGruffins force-pushed the suppressstakestatus branch from 51f55f5 to 7c7bfc6 Compare May 24, 2024 01:48

deps: Update wallet to v4.1.0

a8d7dbf

JoeGruffins force-pushed the suppressstakestatus branch from 65739da to a8d7dbf Compare May 27, 2024 03:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dcr: Allow ticket purchasing for rpc spv wallets #2756

dcr: Allow ticket purchasing for rpc spv wallets #2756

JoeGruffins commented May 2, 2024

JoeGruffins commented May 2, 2024

JoeGruffins May 7, 2024

martonp May 12, 2024

buck54321 May 18, 2024

JoeGruffins May 20, 2024

JoeGruffins May 7, 2024 •

edited

JoeGruffins commented May 7, 2024

JoeGruffins May 7, 2024

martonp May 12, 2024

buck54321 May 18, 2024

martonp May 12, 2024

buck54321 left a comment

buck54321 May 18, 2024

buck54321 May 18, 2024

JoeGruffins May 20, 2024

JoeGruffins May 20, 2024

buck54321 May 18, 2024

JoeGruffins commented May 20, 2024

JoeGruffins commented May 20, 2024

JoeGruffins commented May 27, 2024

		// Calling w.rpcClient.GetTickets too close together will return no
		// tickets for the second call. A ticket cache alleviates this.

dcr: Allow ticket purchasing for rpc spv wallets #2756

Are you sure you want to change the base?

dcr: Allow ticket purchasing for rpc spv wallets #2756

Conversation

JoeGruffins commented May 2, 2024

JoeGruffins commented May 2, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JoeGruffins May 7, 2024 • edited

Choose a reason for hiding this comment

JoeGruffins commented May 7, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

buck54321 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JoeGruffins commented May 20, 2024

JoeGruffins commented May 20, 2024

JoeGruffins commented May 27, 2024

JoeGruffins May 7, 2024 •

edited