Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node): patch MessagePort in worker_thread message #23871

Merged
merged 2 commits into from
May 20, 2024
Merged

fix(node): patch MessagePort in worker_thread message #23871

merged 2 commits into from
May 20, 2024

Conversation

marvinhagemeister
Copy link
Contributor

@marvinhagemeister marvinhagemeister commented May 17, 2024 •
edited

Our MessagePort to Node's MessagePort conversion logic was missing the case where a MessagePort is sent inside the message. This broke tinypool which is used by vitest as it relies on some node specific methods on MessagePort.

Fixes #23854 , Fixes #23871

bartlomieju
bartlomieju approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice catch

@marvinhagemeister marvinhagemeister merged commit d7709da into main May 20, 2024
17 checks passed
@marvinhagemeister marvinhagemeister deleted the node-worker-port branch May 20, 2024 13:01
bartlomieju pushed a commit that referenced this pull request May 21, 2024
@marvinhagemeister @bartlomieju
fix(node): patch MessagePort in worker_thread message (#23871)
d0873a0 
Our `MessagePort` to Node's `MessagePort` conversion logic was missing
the case where a `MessagePort` is sent _inside_ the message. This broke
`tinypool` which is used by `vitest` as it relies on some node specific
methods on `MessagePort`.

Fixes #23854 , Fixes
#23871
bartlomieju pushed a commit that referenced this pull request May 21, 2024
@marvinhagemeister @bartlomieju
fix(node): patch MessagePort in worker_thread message (#23871)
8d4eb21 
Our `MessagePort` to Node's `MessagePort` conversion logic was missing
the case where a `MessagePort` is sent _inside_ the message. This broke
`tinypool` which is used by `vitest` as it relies on some node specific
methods on `MessagePort`.

Fixes #23854 , Fixes
#23871
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: worker_threads missing MessagePort conversion in deeply nested object
2 participants
@marvinhagemeister @bartlomieju