Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch chrono to use now feature and remove custom now implementations #22864

Closed
mmastrac opened this issue Mar 12, 2024 · 3 comments · Fixed by #23888
Closed

Switch chrono to use now feature and remove custom now implementations #22864

mmastrac opened this issue Mar 12, 2024 · 3 comments · Fixed by #23888
Labels
good first issue Good for newcomers refactor

Comments

@mmastrac
Copy link
Contributor

This will allow us to remove the utc_now function.

Feature landed in:

chronotope/chrono#1343
@mmastrac mmastrac added refactor good first issue Good for newcomers labels Mar 12, 2024
@muddlebee
Copy link
Contributor

taking this up as well 👀

@anukulrathore
Copy link

@muddlebee are you working on this, can i start working on it?

@fbaltor fbaltor mentioned this issue May 19, 2024
Merged
@fbaltor
Copy link
Contributor

fbaltor commented May 19, 2024

I guess my PR fixes the issue. But there is an error in the test debug macos-x86_64 and I don't know how to better investigate it.

bartlomieju added a commit that referenced this issue May 23, 2024
@fbaltor @bartlomieju
refactor: remove custom utc_now in favor of chrono::Utc:now featu…
fa1ba25 
…re (#23888)

This PR removes the use of the custom `utc_now` function in favor of the
`chrono` implementation. It resolves #22864.

---------

Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: remove custom utc_now in favor of chrono::Utc:now feature fbaltor/deno
4 participants
@mmastrac @muddlebee @fbaltor @anukulrathore