-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extending resource management to include build containers #3826
Comments
What if you actually had a |
Would you need to define a command in the Procfile or could there be a system default based on the deployment method chosen (buildpack, Dockerfile, etc)? But I like this idea as it would work with the existing resource management interface. |
I wonder if we could do a github search of all Procfiles that have a I think bigquery has github as a dataset, but not sure if the above is something we can query... |
Some resources on Procfiles:
Only the Based on the above procfiles, it seems safe to say that those are helper entries for building apps, so we could definitely special-case it in Dokku and have caveats around it's usage in our docs. |
Okay finally getting back to this, we can definitely support it at the We'll want to expose this via the We also need to filter out certain resources from anything but the We should add resources limits to the lambda builder (it should support anything the Finally, we should use resource limits, not resource reservations. |
Feature request / discussion - we've been using the docker-options subcommands to set CPU and memory constraints on build containers, e.g.
Would be great if we could manage it through the newer resource:limit subcommand.
Perhaps setting --process-type to "build" would have a special meaning here. Thoughts?
The text was updated successfully, but these errors were encountered: