-
Notifications
You must be signed in to change notification settings - Fork 872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tray icon didn't show unpause on computer wake, while GUI icon did #5186
Comments
Are you sure it was not a visual refresh bug on Windows side? When I launch debug instances, sometimes the tray icons don't disappear instantly. I had 4-5 icons shown minutes later, even though the processes were killed. They normally disappear when you mouse over the icons. |
I'm used to seeing dead Duplicati leave tray icons around until I mouse over them (then they disappear). This one not only stayed when I moused over it, but the right click menu could be displayed, and it turned green (as it should) when the backup was active, then solid black when done (as opposed to black with pause bars). Another potential pitfall (for me) is that I'm now running 2.0.8.1 Beta in the main system tray and 2.0.8.108 Debug in the uparrow expansion of the system tray. To remove possibility of confusion, I quit the Debug version while trying to sort out the Beta version. A correction I'll make on myself is that tracing JavaScript is probably relevant only to the browser side (which worked), but I didn't trace whatever C# (presumably) code makes the tray icon change. Now that it's a new day, I did GitHub search on |
One thing that's curious is that when the problem was happening, there were more connections, at least on one snapshot.
Anything ESTABLISHED is double-counted by simple findstr, so filter visually for the LISTEN port on left, and LISTEN PID on right. EDIT: The same (up since May 10) Duplicati now looks like these, when idle and with an idle icon.
|
Based on the traces from @ts678 it looks like it is a visual issue. |
I think I just got this again on wake this morning. Anything I should be looking at differently?
I haven't done Wireshark (or much) on this, but I saved the old .pcapng in case SuggestedStatusIcon was changing and I missed it. EDIT 1:
I'm not sure why log time is 7 seconds delayed, but I'm pretty sure the Active is related to the backup I had started. EDIT 2: Capture looks something like this. After time is the TCP client port number:
EDIT 3: Icon looks OK after wake this morning (May 28), on the same process and without anything new in profiling log.
I looked at Duplicati with a debugger after problem went away, and I now have at least a vague idea of the code. |
Environment info
Description
After bringing the PC out of sleep today, I noticed that the tray icon was still paused despite a 0 second delay configured in Settings.
About --> System info pauseTimeRemain said it had 0 seconds left. The GUI icon at top of home screen showed the unpaused state.
Wireshark traces of the TrayIcon process to itself seem to agree. I couldn't trace the JavaScript, so instead I ran a backup and the icon went green and then back to the normal solid black (without the pause bars). I did another sleep/wake, and problem did not reoccur.
This Duplicati has no scheduled jobs, and no job was in progress overnight, as evidenced by the gap in the server profiling log below:
This sort of problem gets mentioned occasionally in reports, but I'm not sure anyone has reported the differences in the two displays.
I'm almost certain nobody has provided Wireshark displays. I'm not sure if anyone tested a run to prove that it was just a bad display.
Steps to reproduce
TrayIcon shows paused.
TrayIcon shows ready.
Screenshots
Debug log
Wireshark during the odd paused TrayIcon:
Wireshark during the run of next backup:
The text was updated successfully, but these errors were encountered: