Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Linter/Formatter for CMake files #1368

Open
4 tasks
dkroenke opened this issue May 20, 2022 · 1 comment · May be fixed by #1885
Open
4 tasks

Add Linter/Formatter for CMake files #1368

dkroenke opened this issue May 20, 2022 · 1 comment · May be fixed by #1885
Assignees
Labels
good first issue Good for newcomers tooling All iceoryx related tooling (scripts etc.)

Comments

@dkroenke
Copy link
Member

Brief feature description

Since we have some CMake code to maintain, it make sense to enforce on this code also code quality rules like we do with the C++ code.

A possible tool-framework could be cmakelang which offers tooling for formatting and linting CMake Code properly.
Other suggestions are always welcome.

Detailed information

  • Evaluate and decide on a good tool for Linting/Formatting CMake code
  • Add a pre-commit hook for checking on style issues in CMake code (similar to clang-format)
  • Add a CI check to the pre-flight check for checking all CMake Codes on violations
  • reformat and fix all linting violations in all CMake code in iceoryx
@dkroenke dkroenke added good first issue Good for newcomers tooling All iceoryx related tooling (scripts etc.) labels May 20, 2022
@dkroenke dkroenke self-assigned this Feb 7, 2023
@dkroenke
Copy link
Member Author

dkroenke commented Feb 7, 2023

@zmostafa Will work on that ticket.

zmostafa added a commit to zmostafa/iceoryx that referenced this issue Feb 8, 2023
Signed-off-by: Ziad Mostafa <ziad.mostafa@apex.ai>
zmostafa added a commit to zmostafa/iceoryx that referenced this issue Feb 8, 2023
Signed-off-by: Ziad Mostafa <ziad.mostafa@apex.ai>
@zmostafa zmostafa linked a pull request Feb 8, 2023 that will close this issue
21 tasks
zmostafa added a commit to zmostafa/iceoryx that referenced this issue Feb 13, 2023
Signed-off-by: Ziad Mostafa <ziad.mostafa@apex.ai>
zmostafa added a commit to zmostafa/iceoryx that referenced this issue Feb 13, 2023
Signed-off-by: Ziad Mostafa <ziad.mostafa@apex.ai>
zmostafa added a commit to zmostafa/iceoryx that referenced this issue Feb 13, 2023
Signed-off-by: Ziad Mostafa <ziad.mostafa@apex.ai>
zmostafa added a commit to zmostafa/iceoryx that referenced this issue Feb 13, 2023
Signed-off-by: Ziad Mostafa <ziad.mostafa@apex.ai>
zmostafa added a commit to zmostafa/iceoryx that referenced this issue Feb 13, 2023
Signed-off-by: Ziad Mostafa <ziad.mostafa@apex.ai>
zmostafa added a commit to zmostafa/iceoryx that referenced this issue Feb 13, 2023
Signed-off-by: Ziad Mostafa <ziad.mostafa@apex.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers tooling All iceoryx related tooling (scripts etc.)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant