-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test and build errors on Java 11 #459
Comments
The tests are failing with this diff (note
|
The problem here is the date time formatter was using default locale. Not sure why the calculation and resulting output is different between Java 8 and 11. I have fixed this with b5a2b94 which adds a new constructor that takes the locale and the tests pass in the US locale so we can do string comparisons. |
I fixed a bunch of the Java11 javadoc issues in 820be56 - but some of the links were problematic. In particular I couldn't get this link to work in Java 8 and 11 at the same time. The current code renders properly in Java 8: https://github.com/eclipse/lsp4j/blob/c0b921895b4576feeb355eea7a053a0d56daba7b/org.eclipse.lsp4j/src/main/java/org/eclipse/lsp4j/util/SemanticHighlightingTokens.java#L134 |
Are there any issues left or this can be closed? |
I can't remember - need to try using Java 11 and see if it complains. I can see that SemanticHighlightingTokens no longer exists, so that may have solved the problem. |
i dont see any compile and test errors with 11. |
Running LSP4J's build with Java 11 has numerous warnings and errors, such as:
warning - invalid usage of tag >
and similar in many javadocsTracingMessageConsumerTest
has many test failuresThe text was updated successfully, but these errors were encountered: