Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

javax.websocket #647

Open
cdietrich opened this issue Jul 9, 2022 · 4 comments
Open

javax.websocket #647

cdietrich opened this issue Jul 9, 2022 · 4 comments

Comments

@cdietrich
Copy link
Contributor

cdietrich commented Jul 9, 2022

build uses javax.websocket from orbit, which is no longer available in newer orbit versions.
we might have to use a newer orbit version for a newer gson eventually.

=> how to resolve? is jakarta.websocket a feasible alternative? so that we can drop the javax one?

or do we need to restore javax.websocket on orbit

@pisv
Copy link
Contributor

pisv commented Jul 10, 2022

=> how to resolve? is jakarta.websocket a feasible alternative? so that we can drop the javax one?

I don't think so, see #536. Could not we just stick to the last available javax.websocket from Orbit?

@cdietrich
Copy link
Contributor Author

I think we can, just makes the target file more complicated / less straight forward

@jonahgraham
Copy link
Contributor

The long term plan could be to remove the org.eclipse.lsp4j.websocket bundle (as was tried and reverted in #536)

I don't know how to do that in the short term without causing problems to people such as @mitasov-ra who may still be on it.

But since javax.websocket isn't being developed anymore I recommend the first step is to deprecate org.eclipse.lsp4j.websocket and no longer include it in the SDK and SimRel so that it is only available to those that need it by going directly to the maven coordinates for it, or to the LSP4J p2 repo.

If we don't hear any further complaint or request for maintenance on it, we can delete it in a couple of years.

jonahgraham added a commit that referenced this issue Feb 13, 2024
The bundle has been annotated deprecated for removal in a future
version.

The bundle will not be part of the SDK feature, nor part of SimRel
going forward.

Part of #647
jonahgraham added a commit that referenced this issue Feb 13, 2024
…803)

The bundle has been annotated deprecated for removal in a future
version.

The bundle will not be part of the SDK feature, nor part of SimRel
going forward.

Part of #647
@jonahgraham
Copy link
Contributor

first step is to deprecate

Done in #803

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants