Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to include viewport changes into the animations of model updates #147

Open
NiklasRentzCAU opened this issue Nov 13, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@NiklasRentzCAU
Copy link
Contributor

As far as I can tell, animations done during an UpdateModel are something very different from viewport animations such as the center- or the fit to screen animations and are not interoperable. I suggest that you can send a viewport change as an option in the update model action, whose animation is then merged with the animation of the updated model.
This will allow interaction with the diagram that causes a model update via a new layout or something similar to also cause the model to be fit to the screen again as it is wanted in #121 in the same animation. It also allows to define and include some new viewport animation that causes some selected element to stay at the same position on screen although it has a new position in the updated model.

@spoenemann
Copy link
Contributor

This would also solve #121 and #164.

@spoenemann spoenemann added the enhancement New feature or request label Nov 6, 2023
@dhuebner
Copy link
Contributor

dhuebner commented Dec 4, 2023

It also allows to define and include some new viewport animation that causes some selected element to stay at the same position on screen although it has a new position in the updated model.

This part is implemented in the "Random graph" example using TrackSelectedUpdateModelCommand.
For fit or center to screen we can provide a more complex implementation that allows this by adding an additional ViewAnimation taking the newRoot boundaries into account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants