Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVG export postprocessor #454

Merged
merged 2 commits into from
May 28, 2024
Merged

Conversation

gfontorbe
Copy link
Contributor

Closes #421

Adds the possibility to inject a SVG export postprocessor to manipulate the produced SVG element during an export.

Adds the possibility to skip the copying of styles on the exported SVG elements to improve performance.

Fix a bug with the exported viewport calculated on the wrong element.

Signed-off-by: Guillaume Fontorbe <guillaume.fontorbe@typefox.io>
@gfontorbe gfontorbe requested a review from spoenemann May 13, 2024 15:09
Copy link
Contributor

@spoenemann spoenemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just two details

packages/sprotty/src/features/export/export.ts Outdated Show resolved Hide resolved
packages/sprotty/src/features/export/svg-exporter.ts Outdated Show resolved Hide resolved
Signed-off-by: Guillaume Fontorbe <guillaume.fontorbe@typefox.io>
@gfontorbe gfontorbe requested a review from spoenemann May 15, 2024 06:45
Copy link
Contributor

@spoenemann spoenemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gfontorbe gfontorbe merged commit e36c87c into master May 28, 2024
2 checks passed
@gfontorbe gfontorbe deleted the gfontorbe/svg-export-postprocessor branch May 28, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Self-contained SVG Export
2 participants