Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom limits are not optional #441

Open
NiklasRentzCAU opened this issue Feb 28, 2024 · 0 comments
Open

Zoom limits are not optional #441

NiklasRentzCAU opened this issue Feb 28, 2024 · 0 comments
Labels
good first issue Good for newcomers sprotty Issue concerning the main sprotty package

Comments

@NiklasRentzCAU
Copy link
Contributor

The zoom limits, as introduced in #356, force the configuration of some zoom limit, just overriding the zoom limits in the viewer options to zoomLimits: undefined will cause an error when zooming:

zoom.js:72 Uncaught TypeError: Cannot read properties of undefined (reading 'min')
    at ZoomMouseListener.processZoom (zoom.js:72:1)

We have a use case (the new top-down layout in ELK) that makes it sensible to zoom arbitrarily deep into hierarchical graphs, so no limit number can turn this off. I would propose that setting this option to undefined or the limit numbers to something like -1 causes the limits to be ignored entirely.

@NiklasRentzCAU NiklasRentzCAU added good first issue Good for newcomers sprotty Issue concerning the main sprotty package labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers sprotty Issue concerning the main sprotty package
Projects
None yet
Development

No branches or pull requests

1 participant