Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Considering set(paths) for the calculation of the Position based attribution #9

Open
hrithwikk opened this issue Apr 9, 2024 · 0 comments

Comments

@hrithwikk
Copy link

Hi,

I observed that the code is considering the set of paths (taking only the distinct elements present in that path.) instead of paths as a whole

wouldn't be an issue when we have position based attribution running for multiple paths but with same journey ? also when the same channel comes more than once within the path ?

context : i have been facing issues on such cirumstances when i tried running the logic by using window functions. the current code seems to be iterating through the rows one by one, so I felt this approach would be better.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant