Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support gRPC context propagation in grpcproxy #18012

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support gRPC context propagation in grpcproxy #18012

wants to merge 1 commit into from

Conversation

ximenzaoshi
Copy link

…e problem that watch exits when recvLoop exits but sendLoop still running

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

Trying to fix #18011.

@k8s-ci-robot
Copy link

Hi @ximenzaoshi. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ximenzaoshi ximenzaoshi mentioned this pull request May 15, 2024
Open
4 tasks
@ivanvc
Copy link
Member

ivanvc commented May 15, 2024

Hi, @ximenzaoshi, thanks for your PR. It seems like you didn't sign your commit. Could you please amend your commit and push it again? so the developer certificate of origin (DCO) check passes, i.e:

git commit --amend --signoff # Fix the signed off trailer
git push --force

@ximenzaoshi ximenzaoshi force-pushed the fix_grpc_proxy branch 3 times, most recently from 8cc31c0 to 995c623 Compare May 17, 2024 06:05
@ximenzaoshi
fix(grpcproxy): support grpc context propagation in grpc proxy;fix th…
1282b04 
…e problem that watch exits when recvLoop exits but sendLoop still running

Signed-off-by: ximenzaoshi <wanglu_bx@163.com>
@jmhbnz
Copy link
Member

jmhbnz commented May 20, 2024

/ok-to-test

@henrybear327
Copy link
Contributor

Hi @ximenzaoshi, it would be nice if the PR title could be updated! :)

@ivanvc
Copy link
Member

ivanvc commented May 20, 2024

/retitle Support gRPC context propagation in grpcproxy

@k8s-ci-robot k8s-ci-robot changed the title fix(grpcproxy): support grpc context propagation in grpc proxy;fix th… Support gRPC context propagation in grpcproxy May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanvc ivanvc ivanvc left review comments

Assignees
No one assigned
Labels
ok-to-test
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Grpc-proxy cannot handle requests from grpc-gateway correctly
5 participants
@ximenzaoshi @k8s-ci-robot @ivanvc @jmhbnz @henrybear327