Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

DS Implementation - SkipNav #12929

Open
TylerAPfledderer opened this issue May 8, 2024 · 17 comments
Open

DS Implementation - SkipNav #12929

TylerAPfledderer opened this issue May 8, 2024 · 17 comments
Assignees
Labels
design required 馃帹 This involves design changes design system this label will be used in all issues related to design system dev required This requires developer resources help wanted Extra attention is needed or someone is needed to help

Comments

@TylerAPfledderer
Copy link
Contributor

TylerAPfledderer commented May 8, 2024

馃毃As of the initial posting of this issue, a new design needs to be created in Figma by @nloureiro before executing this update. The issue can still be assigned by a contributor in the meantime.

Update the existing SkipNav component to use a new design.

Currently, this component is fully custom in it's styles and handling of the link redirect to content in the given page. Recommend investigating the use of the SkipNavLink and SkipNavContent provided by Chakra to handle in consideration of accessibility.

Be aware that SkipNavLink under the hood renders a primitive a tag with needed logic passed to it. We should retain this render, as its only job is to send the user to the specified section of content.

It also has it's own theme config SkipLink. See source code.

In summary of initial recommendations:

  • Remove the custom SkipLink file in favor of keeping styling in the component theme configuration
  • Any translated content and href can be supplied at the parent level RootLayout.
  • Import SkipNavLink / SkipNavContent directly from Chakra

cc @pettinarip Do NOT assign me! 馃槄

@github-actions github-actions bot added the needs triage 馃摜 This issue needs triaged before being worked on label May 8, 2024
@wackerow wackerow added help wanted Extra attention is needed or someone is needed to help dev required This requires developer resources design system this label will be used in all issues related to design system design required 馃帹 This involves design changes and removed needs triage 馃摜 This issue needs triaged before being worked on labels May 9, 2024
@murluki
Copy link

murluki commented May 9, 2024

Could you assign me, please?

@Dharmik79
Copy link

@wackerow I want to work on this issue, once the Figma design is updated.

@nloureiro
Copy link
Contributor

@murluki are you able to do the Figma design proposal?

@murluki
Copy link

murluki commented May 13, 2024

@nloureiro yes, I can help you with this.

@nloureiro
Copy link
Contributor

@nloureiro yes, I can help you with this.

great! will you create a Figma file? or do you want me to create one.

@pettinarip
Copy link
Member

@murluki just to clarify, are you doing the design and the implementation in the code? or just the design part? assigning to you in the meantime.

@murluki
Copy link

murluki commented May 13, 2024

@nloureiro could you please create the Figma file?
@pettinarip I鈥檒l be doing the front end coding part for this task.

@nloureiro
Copy link
Contributor

@nloureiro could you please create the Figma file? @pettinarip I鈥檒l be doing the front end coding part for this task.

go for it!!!
https://www.figma.com/design/EecunGD6oTh62h7rdukaFL/Skip-Nav-component?node-id=1%3A49&t=lHyaiG0J1dR9xp0Q-1

Thank you for your collaboration

@TylerAPfledderer
Copy link
Contributor Author

@pettinarip @murluki I updated this issue's description to give better clarity in describing what Chakra's SkipNavLink renders.

@surajpsuresh
Copy link

Hi I would like to help out on this, is it possible to assign me also to this?

@murluki
Copy link

murluki commented May 19, 2024

@surajpsuresh Hi, I am actually done with it and will be pushing it tonight

@surajpsuresh
Copy link

Okay cool

@surajpsuresh
Copy link

@murluki Is it possible to talk to you regarding contributing, best practices and how to actually share design work on GitHub.
I have been looking at tutorials online, but would rally appreciate talking to an actual person on how to navigate in GitHub.

Any time that is convenient for you would work!

Cheers!

@murluki
Copy link

murluki commented May 19, 2024

@surajpsuresh of course, if you have telegram, hit me up at murluki_prg. I can share some tips with you :)

@surajpsuresh
Copy link

Done

@TylerAPfledderer
Copy link
Contributor Author

@murluki and @surajpsuresh you may reach out to me if you need any clarification of the requirements! 馃榿

@surajpsuresh
Copy link

@murluki and @surajpsuresh you may reach out to me if you need any clarification of the requirements! 馃榿

Sure @TylerAPfledderer will do, I guess @murluki has completed this for now, keeping an eye out for any new design tasks that may pop up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design required 馃帹 This involves design changes design system this label will be used in all issues related to design system dev required This requires developer resources help wanted Extra attention is needed or someone is needed to help
Projects
None yet
Development

No branches or pull requests

7 participants