Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug report - overlapping elements #12965

Open
1 of 2 tasks
wackerow opened this issue May 15, 2024 · 2 comments
Open
1 of 2 tasks

Bug report - overlapping elements #12965

wackerow opened this issue May 15, 2024 · 2 comments
Labels
bug 🐛 Something isn't working dev required This requires developer resources good first issue Good item to try if you're new to contributing low priority This has a low priority

Comments

@wackerow
Copy link
Member

Describe the bug

The LanguagePicker component has a keyboard shortcut [\] available, which is noted inside the text input to filter languages once the menu is open. In left-to-right (LTR) languages this works well, but with right-to-left (RTL) languages (fa, he, ar, ur) this keyboard shortcut indicator is not adjusting to the left side of the input, causing it to overlap with the placeholder/input text.

To reproduce

  1. Go to https://ethereum.org/he/
  2. Click on HE (language menu top left)
image 3. See overlapping elements

Expected behavior

Keyboard shortcut indicator [\] should be on the left for RTL languages, and should also not overlap the clearing X once user starts typing.

Screenshots

image

Desktop (please complete the following information)

No response

Smartphone (please complete the following information)

No response

Additional context

No response

Would you like to work on this issue?

  • Yes
  • No
@wackerow wackerow added the bug 🐛 Something isn't working label May 15, 2024
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label May 15, 2024
@wackerow wackerow added low priority This has a low priority good first issue Good item to try if you're new to contributing dev required This requires developer resources and removed needs triage 📥 This issue needs triaged before being worked on labels May 15, 2024
@MukulKolpe
Copy link
Contributor

Hey @wackerow, can I work on this one?

@MartiPresa
Copy link

Hi, is this issue still available?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something isn't working dev required This requires developer resources good first issue Good item to try if you're new to contributing low priority This has a low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wackerow @MukulKolpe @MartiPresa