Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display user avatars using their actual email adress #482

Closed
abompard opened this issue Apr 19, 2024 · 4 comments
Closed

Display user avatars using their actual email adress #482

abompard opened this issue Apr 19, 2024 · 4 comments
Labels

Comments

@abompard
Copy link
Member

In the Badges system, everybody's "email" address is fasusername@fp.o, because users are keyed on email addresses and not nicknames. But FAS has the actual email address that a user may have set their libravatar on.
Tahrir should ask FASJSON what the user's actual email address is to build the libravatar URL. This request should be cached for a reasonable amount of time (or, to be fancier, invalidated by fedbadges when a FAS message comes in about a user changing their email address).

@abompard
Copy link
Member Author

Another way would be to cache the email address when the user logs in to Tahrir, because it's available in the profile that Ipsilon gives us.
When changing it in Noggin they'd have to login to Tahrir again to see it updated (or maybe a fedora-messaging consumer could update that automatically).

@abompard abompard added the good first issue Good for new contributors label Apr 24, 2024
@abompard
Copy link
Member Author

For the record, in the previous version, the user's avatar was resulting from a query to libravatar with their openid identifier. That's not good either.

@ryanlerch ryanlerch added the todo label May 1, 2024
@abompard
Copy link
Member Author

Done in 64c3abc

@penguinpee
Copy link

Thanks a lot! The front page looks way more familiar now. 🤩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants