Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wesnoth's 1.14 oldstable branch #5264

Open
loonycyborg opened this issue May 18, 2024 · 4 comments
Open

Wesnoth's 1.14 oldstable branch #5264

loonycyborg opened this issue May 18, 2024 · 4 comments
Labels
eol Needs manually EOL-ed or purged from repo

Comments

@loonycyborg
Copy link

Wesnoth's stable branch currently is 1.18 yet it's impossible to add 1.16 since custom branches aren't supported anymore. But there still exists 1.14 oldstable branch which probably should be removed for consistency.

$ flatpak --user remote-ls flathub | grep wesnoth
Битва за Веснот org.wesnoth.Wesnoth     1.14.17 1.14
Битва за Веснот org.wesnoth.Wesnoth     1.18.0  stable
@bbhtt
Copy link
Contributor

bbhtt commented May 19, 2024

branch/foo was always reserved for baseapps and extensions. This started being enforced recently.

@bbhtt bbhtt added the eol Needs manually EOL-ed or purged from repo label May 19, 2024
@soliton-
Copy link

branch/foo was always reserved for baseapps and extensions. This started being enforced recently.

I cannot tell what this means. Will the 1.14 branch get deleted at some point?

@bbhtt
Copy link
Contributor

bbhtt commented May 30, 2024

Will the 1.14 branch get deleted at some point?

It will, the version that is published on that branch needs to be removed from the Flathub repository first. Then we can delete the Git branch.

I cannot tell what this means.

It means applications were not supposed to use branches branch/foo branches on Github. This was allowed previously but not any longer.

@loonycyborg
Copy link
Author

It seems that I also can't remove branch/foo branches from org.wesnoth.Wesnoth github repo because of branch protection rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
eol Needs manually EOL-ed or purged from repo
Projects
None yet
Development

No branches or pull requests

3 participants