Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ErrorStatus of AudioFiles not checked after creation #5

Open
weefuzzy opened this issue Sep 28, 2020 · 0 comments
Open

ErrorStatus of AudioFiles not checked after creation #5

weefuzzy opened this issue Sep 28, 2020 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@weefuzzy
Copy link
Member

IAudioFile does all its parsing in the constructor, and sets an error flag if a problem is encountered. We're not checking that flag, which means worse things can happen further down the line if a file has not been read successfully.

See this forum post: https://discourse.flucoma.org/t/using-extended-wav-format-throws-floating-point-exception-for-cli-reacoma-versions/663

The root problem here is that IAudioFile barfs on the Wave Extensible FMT chunk, but doesn't give as a good an error as it could (instead of 'unsupported format', one gets a mysterious floating point exception). [I shall see about getting support for the wav extensible header added to the HISSTools audio file library]

@weefuzzy weefuzzy added the bug Something isn't working label Sep 28, 2020
@weefuzzy weefuzzy self-assigned this Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant